Monday - 17-7-2023
1. INRB 626 - 30 min 
Changed the colour  and the look of the modules - submitted the pr.
For this the import CSV is not implemented.
Asked sanyam to check that because that is the  main task to be done.
Changing the colour  for the numbers.

To do - 4.1 tasks release notes - 2  hours 

SMS option is not done in the APP - 
Woirking on it 
INRT 457 - 2 hours 

INRB 633
Sorting is there for the model in assets 
For the incidents involved  -
[18:04] Gopika Singh
this sorting is from api's end
[18:04] Gopika Singh
and they said that
[18:05] Gopika Singh
since the values in these are coming from a different table - sorting can't be added in that
[18:05] Gopika Singh
Raj agreed to remove sorting from here

Issue : INRB 642, INRB 645
The columns headers are not aligned with the other column headers, the sorting button is up and the header remains in bottom.
Expected: The text should be aligned with the sort button. fixed this 
 like 1
Issue:
1.There is no sort button for text,file url, link, notified users, status.  this is fixed.
2.There is sort button for action header, which should not be the case.



[17:35] Rajkumar Pativada

Rajkumar Pativada

📷


This is the 1st one to start with


[17:36] Rajkumar Pativada

vertical spacing between the fields is uniform.

[17:39] Rajkumar Pativada

Sanjana was saying she raised this bug and someone gave some nonsensical explanation?

[17:40] Rajkumar Pativada

Is that you or Shivkant?

[17:45] Rajkumar Pativada

2. Track history heading should be top aligned.

3. Last incident created on is wrong in admin portal showing future dates

[17:46] Rajkumar Pativada

4. In the app, we have a message saying OTP will be sent on SMS right, there we also have to mention that OTP will be sent on whatsapp also, give me the current text, I will give the updated text.

[17:52] Rajkumar Pativada

5. In admin portal - Enable SMS notifications - Not sure who worked on this - but it's common sense that radio buttons/checkboxes should be connected with their labels, so that they are clickable. Can't expect user to click on circle/square to select or deselect. Worst part is there are other radio buttons in the same page which are done properly, didn't even use that code.

 

6. Enable SMS notifications - Based on this flag I clearly mentioned we have to show/hide sms option in "All applicable places". Nobody asked me what are those applicable places, you guys only did in notifications popup and left escalations. "Text message" in escalations should also be handled accordingly.

[17:53] Rajkumar Pativada

 

 

[17:53] Rajkumar Pativada

7. Incorrect colspan



Wednesday: 19-7 2023
INRB 590 - 5 hours

THursday - 20-7-2023

INRT 564 - 2 hours , if the APi doc is ready 
INRT 566 - avoid asking location when the user logs in  - 2 hours 

INRT 535 - Allow users to disconnect from App  - 30 min 

INRT 538 - Show all incidents in Feed also handle it accordingly in the app - 3 hours

INRB - 588 -  3 hours 
need to have call with sanjana    733172
Resolved the issue 
Angular forum question 1 
1. https://datatables.net/forums/discussion/comment/222672#Comment_222672 with answers 
2. https://datatables.net/forums/discussion/comment/222672#Comment_222672 with answers  

INRB 661 - 1 hour 

INRB 611- 1 hour
Friday : 21-7-2023
INRB 611 -  2 hours 
[15:53] Gopika Singh
Abhilash Anand Katta
but it is only calling one orgId
in organization filter
[15:53] Gopika Singh
only one organization can be selected at once
[15:53] Gopika Singh
not multiple
[15:54] Gopika Singh
because the graph can show only one org data
[15:54] Gopika Singh
just like in portal
The dashboard thing is sorted but the thing is the organisations which are not there in the account are also shown .
INRB 664 - 2 hours 
call with same regarding the count - 40 min 
There is anissue with the data , in APP we care calling Incident sites , 
but if we console , we are getting location Name 


For push notifications -  Images  or nothing else.

App bugs -
In notifications - the sites are not matching with orgs.
Mobile app users - even mobile APP users are also getting IsAppusers : false ;

Things to learn in Angular .
Event emitter - most important.
ANGULAR LIFE CYCLE HOOKS
Angular Models
IONIC certification.